Skip to content

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Sep 12, 2016

What is this PR for?

sparkr.zip is not distrubuted to executor, so any sparkR job that requrie R daemon in executor will fail. This PR would add sparkr.zip into spark.yarn.dist.archives.

What type of PR is it?

[Bug Fix]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Run the following code

%spark.r

df <- createDataFrame(sqlContext, mtcars)
showDF(df)

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu
Copy link
Contributor Author

zjffdu commented Sep 12, 2016

@Leemoonsoo Please help review.

@Leemoonsoo
Copy link
Member

@zjffdu Do you think rpkg.zip is the something also need to be taken care?

@zjffdu
Copy link
Contributor Author

zjffdu commented Sep 14, 2016

@Leemoonsoo The rpkg.zip is for the case that user have R code inside of jars specified through --jars. The reason why I didn't include it here is that I have to duplicate lots of code from spark (most of them is private, I have to copy them to zeppelin). Besides I think very few people would include R inside of jars. So I think it is acceptable to not include it for now.

BTW, I think zeppelin still duplicate lots of code of SparkSubmit, I plan to improve them in ZEPPELIN-1263.

@Leemoonsoo
Copy link
Member

Thanks for the explanation.
LGTM and merge if there're no more discussions.

asfgit pushed a commit that referenced this pull request Sep 15, 2016
### What is this PR for?
sparkr.zip is not distrubuted to executor, so any sparkR job that requrie R daemon in executor will fail. This PR would add sparkr.zip into `spark.yarn.dist.archives`.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1425

### How should this be tested?
Run the following code
```
%spark.r

df <- createDataFrame(sqlContext, mtcars)
showDF(df)
```

### Screenshots (if appropriate)
![image](https://cloud.githubusercontent.com/assets/164491/18423112/6f7a75de-78d4-11e6-9d0b-ab05d41e3bfb.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <[email protected]>

Closes #1423 from zjffdu/ZEPPELIN-1425 and squashes the following commits:

145a8dc [Jeff Zhang] ZEPPELIN-1425. sparkr.zip is not distributed to executors

(cherry picked from commit 439b76c)
Signed-off-by: Lee moon soo <[email protected]>
@asfgit asfgit closed this in 439b76c Sep 15, 2016
pedrozatta pushed a commit to pedrozatta/zeppelin that referenced this pull request Oct 27, 2016
### What is this PR for?
sparkr.zip is not distrubuted to executor, so any sparkR job that requrie R daemon in executor will fail. This PR would add sparkr.zip into `spark.yarn.dist.archives`.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1425

### How should this be tested?
Run the following code
```
%spark.r

df <- createDataFrame(sqlContext, mtcars)
showDF(df)
```

### Screenshots (if appropriate)
![image](https://cloud.githubusercontent.com/assets/164491/18423112/6f7a75de-78d4-11e6-9d0b-ab05d41e3bfb.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <[email protected]>

Closes apache#1423 from zjffdu/ZEPPELIN-1425 and squashes the following commits:

145a8dc [Jeff Zhang] ZEPPELIN-1425. sparkr.zip is not distributed to executors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants